Re: ossfree version 3.8-beta4 patches, 2.1.24

Keith Owens (
Fri, 31 Jan 1997 09:53:53 +1100

On Thu, 30 Jan 1997 09:54:57 -0500 (EST),
Ion Badulescu <> wrote:
>On Thu, 30 Jan 1997, Keith Owens wrote:
>> - select_wait (&in_sleeper[dev], wait);
>> + poll_wait (&in_sleeper[dev], wait);
>[rest of the patch deleted]
>Broken, broken, broken. That's not the Right Way to do it - take a look at
>Linus' last message and at the 2.1.24 patch for some pointers.

It is the right way to do it, select_wait -> poll_wait is a name change
for the proc and a type change for the second parameter. Hannu had
already changed the rest of the sound code to match 2.1.24 and changed
the second parameter, just missed changing the proc name. Note that
the patch was against 2.1.24 + ossfree version 3.8-beta4, not against
2.1.24 alone.

> It is better to keep your mouth shut and be thought a fool,
> than to open it and remove all doubt.

Like the .sig :).