Re: PNP patch into kernel when?

Andrew E. Mileski (
Thu, 5 Dec 1996 20:04:02 -0500 (EST)

> > There is no standard, and Linus has said he will not impose his
> > preferences on developers. (I tried to get him to, but he refused.)
> There is the defacto loose standard of the majority of the kernel, which
> is (loosely) similar. If you want it codified, there is
> Documentation/CodingStyle.

I know...I lead the charge to have it included in the kernel source.

I apologize for "quoting at you", as it always seems like "bible thumping"
to me...

Linux kernel coding style

This is a short document describing the preferred coding style for the
linux kernel. Coding style is very personal, and I won't _force_ my
views on anybody, but this is what goes for anything that I have to be
able to maintain, and I'd prefer it for most other things too. Please
at least consider the points made here.

Definitely not strict, and I did take some of Linus's preferences to
heart (though I disagree with a few, I followed them anyways).

> > Compare the networking sources, sound driver sources, and ext2 sources,
> > and you will see at least 3 distinct styles for example.
> The sound driver is a seperate package that just gets bolted into the
> kernel. There are lots of ways in which it doesn't "fit" very well. The
> networking sources may still be a bit of a mess because many people have
> hacked on them over the years, and there are probably bits of old Biro
> code floating around. And none of the code I've looked at does anything
> particularly shocking - yes, personal tastes differ on indents and brace
> placement, but I'm not particularly fussed about those.

And 132 columns...

> > If you have specific suggestions, I will consider them. Your use of
> > the word "jarring" doesn't tell me anything, except that you don't
> > approve.
> My specific suggestion, then, is that you reconsider your plan of
> spreading out your function definitions.

Okay, consider it done...not exactly as you asked for, but definitely
fewer lines. See, I'm reasonable :-)

Andrew E. Mileski
Linux Plug-and-Play Kernel Project
XFree86 Matrox Team