Re: PNP patch into kernel when?

Andrew E. Mileski (
Thu, 5 Dec 1996 17:25:48 -0500 (EST)

> I've just been looking at the PnP patch in slightly more detail. Is there
> any chance you could use a slightly more conventional layout style? I
> find that function definitions laid out as
> are a bit visually jarring, and they don't match any other part of the
> kernel that I know of. Since I imagine many people may want to work on
> the resource manager, it seems polite to stick to the standard coding
> style.

Respectfully, I don't think you looked at enough of the kernel source.
There is no standard, and Linus has said he will not impose his
preferences on developers. (I tried to get him to, but he refused.)

Compare the networking sources, sound driver sources, and ext2 sources,
and you will see at least 3 distinct styles for example.

The style I used is actually based on several elements of the style used
in other places in the kernel. I chose those which I found to visually
simplify the code, and lower its "density" for readability, fortryingto

If you have specific suggestions, I will consider them. Your use of
the word "jarring" doesn't tell me anything, except that you don't

Andrew E. Mileski
Linux Plug-and-Play Kernel Project
XFree86 Matrox Team