Re: Bad comment in drivers/block/rd.c?

Theodore Y. Ts'o (tytso@mit.edu)
Tue, 19 Nov 1996 18:23:21 -0500


Date: Tue, 19 Nov 1996 17:29:34 +0100 (MET)
From: Christian Hardmeier <chrigi@infinite.loop.org>

drivers/block/rd.c (from the 2.0.25 source tree) says:

> /*
> * This routine tries to a ramdisk image to load, and returns the
> * number of blocks to read for a non-compressed image, 0 if the image
^^^^^^^^^^^^^^
> * is a compressed image, and -1 if an image with the right magic
^^^^^^^^^^^^^^^^^^^^^
> * numbers could not be found.
> *

Shouldn't the comment say "if it matches the gzip magic numbers, return 0"
rather than "return -1"?

I'm not sure what you're complaining about. The comment says: "return 0
if the image is a compressed image". That is, if the image has the
magic numbers of gzip. It returns -1 if the right magic numbers aren't
there.

- Ted