Re: Small bug in 1.3.76

Ulrich Windl (Ulrich.Windl@rz.uni-regensburg.de)
Thu, 21 Mar 1996 15:41:46 +0100


On 21 Mar 96 at 16:53, Boris Tobotras wrote:

> Lewis Tanzos wrote:
>
> > > In arch/i386/kernel/setup.c there should be "break" in cases inside
> > > the switch where i486model and i586model gets called (sorry, haven't
> > > sources handy).
> >
> >
> > Why?
> >
> > static const char * getmodel (int x86, int model)
> > {
> > switch (x86) {
> > case 4:
> > return i486model(model);
> > case 5:
> > return i586model(model);
default:
return "Unknown";
> > }
> > return "Unknown";
> > }
> >
> > looks fine to me. 'return' is a wonderful thing.

The above seems more logical to me. Why not change it?
>
> Hm. Seems I was wrong here. Why then "cat /proc/cpuinfo" now shows model
> "9" instead of "DX/4-WB" for my AmdDX4-120 (model code 9, indeed )?
> Lewis Tanzos
> --
> Best regards, -- Boris.
>
>
>
>