Re: BUG FIX for 1.3.75: video.S breaks LOADLIN (may be others too)

Martin Mares (mj@k332.feld.cvut.cz)
Mon, 18 Mar 1996 08:31:49 +0100 (MET)


Hi,

> This is not needed, I guess. CAN_USE_HEAP + heap_end_ptr is enough.

OK.

> Ok, in principal I agree. Below is a new patch that prepares what
> should be done, and this could go as well in to the kernel immediatly in
> order to avoid crashes. You then will be able to adapt your stuff without
> hectic.
> Keep in mind: it's not only LOADLIN that gets messed. The stack
> problem relates to _all_ loaders. The only case that is sure, is when
> haveing vga=ask (then store_screen is not called).
>
> The procedere should be as follows (in this order):
>
> 1. We let CAN_USE_HEAP = 0 per default, this would avoid crahes when
> loaded with older loaders.
> If CAN_USE_HEAP set, then also heap_end_ptr contains a valid value.
>
> 2. You adapt video.S to heap_end_ptr usage.
>
> 3. We realize setting CAN_USE_HEAP in the newer loaders (LILO/LOADLIN),
> and after they have been distributed round over the world all will be
> fine.

Thanks for the patch, I'll implement the changes soon.

Martin