Re: slhc symbols not registering if PPP or CSLIP builtin

Perry F Nguyen (pfnguyen@netcom22.netcom.com)
Wed, 6 Mar 1996 15:26:10 -0800 (PST)


-----BEGIN PGP SIGNED MESSAGE-----

On Wed, 6 Mar 1996, Richard Waltham wrote:

> The problem is the following line(s) from ../linux/core/dev.c slhc_install()
> as it says installs the symbols, or should do, for slhc if built in.

> /*
> * SLHC if present needs attaching so other people see it
> * even if not opened.
> */
> #if (defined(CONFIG_SLIP_COMPRESSED) || defined(CONFIG_PPP)) && defined(CONFIG_SLHC_BUILTIN)
> slhc_install();
> #endif

I haven't taken a look to see what slhc_install() does ... but, it
appears to have been compiled into my kernel w/
"grep slhc_install /usr/src/linux/System.map"

I guess slhc_install() doesn't export the slhc symbols properly.

> This should be compiled in if either CSLIP or PPP is built in to the kernel.
> However, on my system at least, no matter what combination of built in or
> module support is applied to CSLIP and PPP, CONFIG_SLHC_BUILTIN is *NEVER*
> seen true *here*, so that line is not compiled into the kernel.

> Looking at the Makefile in ../linux/drivers/net CONFIG_SLHC_BUILTIN is
> always set if SLIP or PPP is built in so maybe the above line should be.

> /*
> * SLHC if present needs attaching so other people see it
> * even if not opened.
> */
> #if (defined(CONFIG_SLIP) || defined(CONFIG_PPP))
> slhc_install();
> #endif

> Is this ok? Should CONFIG_SLHC_BUILTIN be seen true here? Is this a
> problem with my revisions of make/gcc etc. or is it a problem with the make
> files themselves? Presumable CONFIG_SLHC_BUILTIN defined in
> ../linux/drivers/net/Makefile needs exporting to ../linux/core/Makefile
> however that gets done.

> Basic configuration here is gcc 2.5.8, make 3.71, kernel currently 1.3.71.

> Wel, just had a look at the old patch files. The line was originally added
> in patch-1.3.60 and modified to what it now is in patch-1.3.61 - its not my
> version of make causing the problem, is it?

I'd be your cpp from gcc if anything causing a problem, but I doubt that.

- --
| pfnguyen@netcom.com - ftp://ftp.netcom.com/pub/pf/pfn | TCP/IP Networking, |
| 1024/0D97E00D 1995/01/01 Perry "Huy" Francis Nguyen | Unix Systems Admin, |
| CE 62 F2 01 33 87 9D 89 - BC 53 8D 11 F9 A0 DE 8F | and Consulting. |
| FTP, finger or mail with subject PGPKEY for PGP Key | Applications Devel. |

-----BEGIN PGP SIGNATURE-----
Version: 2.6.2

iQCVAwUBMT4fEC2IFwkNl+ANAQEmdwP/ZaxrM6RAiXSUEqwlcBbrDcx5crV5HDSf
Z4oxBMMmo5LAwVEELgJTVKDxLKVxVNzYs8bXac+Kmh/DxZnYE7oD6ZvdGvjHxP88
/8lRbb6vYpKxP4a/Zo1Tu+AJ7pe0Ys/Y0t/HC8w+JMghUOLfPds9IfB9X2MuNrji
c2EAjJ3IPlc=
=Y64Y
-----END PGP SIGNATURE-----