slhc symbols not registering if PPP or CSLIP builtin

Richard Waltham (dormouse@farsrobt.demon.co.uk)
Wed, 6 Mar 1996 20:19:02 +0000 (GMT)


Hi,

I've recently been experimenting getting modules working here but have had
problems with symbols from slhc.c not being exported. Specifically with
CSLIP built in and PPP as a module trying to load the ppp.o module gives
errors regarding slhc symbols not being defined.

I've found if CSLIP or PPP is built in to the kernel the slhc symbols are
not exported.

The problem is the following line(s) from ../linux/core/dev.c slhc_install()
as it says installs the symbols, or should do, for slhc if built in.

/*
* SLHC if present needs attaching so other people see it
* even if not opened.
*/
#if (defined(CONFIG_SLIP_COMPRESSED) || defined(CONFIG_PPP)) && defined(CONFIG_SLHC_BUILTIN)
slhc_install();
#endif

This should be compiled in if either CSLIP or PPP is built in to the kernel.
However, on my system at least, no matter what combination of built in or
module support is applied to CSLIP and PPP, CONFIG_SLHC_BUILTIN is *NEVER*
seen true *here*, so that line is not compiled into the kernel.

Looking at the Makefile in ../linux/drivers/net CONFIG_SLHC_BUILTIN is
always set if SLIP or PPP is built in so maybe the above line should be.

/*
* SLHC if present needs attaching so other people see it
* even if not opened.
*/
#if (defined(CONFIG_SLIP) || defined(CONFIG_PPP))
slhc_install();
#endif

Is this ok? Should CONFIG_SLHC_BUILTIN be seen true here? Is this a
problem with my revisions of make/gcc etc. or is it a problem with the make
files themselves? Presumable CONFIG_SLHC_BUILTIN defined in
../linux/drivers/net/Makefile needs exporting to ../linux/core/Makefile
however that gets done.

Basic configuration here is gcc 2.5.8, make 3.71, kernel currently 1.3.71.

Wel, just had a look at the old patch files. The line was originally added
in patch-1.3.60 and modified to what it now is in patch-1.3.61 - its not my
version of make causing the problem, is it?

Richard

--
Richard Waltham   |                             dormouse@farsrobt.demon.co.uk
  At home in      |                                    Compuserve 100421.1276
Southampton UK    |     FAX + GTPN 050/066 The Board Room +44 (0) 1703 760099
--