Re: Another patch bug...

Theodore Ts'o (
Fri, 29 Sep 1995 15:28:08 -0400

Date: Thu, 28 Sep 1995 14:39:49 -0400 (EDT)
From: Mark Neill <neill@Trenton.EDU>

The patch is screwed up again...the 1.3.30 this time. Linus's
arch/alpha/kernel/time.c patch got applied to my arch/i386/kernel/time.c
file...I'm in the process of hacking it, but it's kinda ugly, and
there's lots of duplicated symbols.

It worked fine for me....

On another topic....Whenever I apply the patch, I get new files
appearing in the directory I patch from (usually /usr/src, with a symlink
to linux-1.3.whatever). It would be nice to include a little textfile
describing the new files, and where to put them in the source tree
structure. Admittedly I can usually figure out when the Make bombs out
or by looking at the filename and seeing that a NCRxxxx.c file is a new
CD-Rom driver, but I'd rather not have to guess...

It looks like you're not reading the README file, and using the -p0 flag
for patch. If you use the -p0 flag, then the files appear in the
correct directory, and you don't have to manually move them. The
correct way to apply patches is:

cd /usr/src
gunzip < patch-1.3.30.gz | patch -p0

or what I generally tend to do is:

cd /usr/src/linux-1.3.30
gunzip < patch-1.3.30.gz | patch -p1

- Ted