sbpcd.c suggestion

Michael H. Price II (mhp1@Ra.MsState.Edu)
Sun, 16 Jul 1995 10:04:35 -0500

In pretty much all kernel versions, the driver for Sound Blaster CD's
(drivers/block/sbpcd.c) contains the following code segment (portion below
taken from 1.3.10):

-----CODE SEGMENT-----
#if DISTRIBUTION
static int sbpcd_debug = (1<<DBG_INF);
#else
static int sbpcd_debug = ((1<<DBG_INF) |
(1<<DBG_TOC) |
(1<<DBG_MUL) |
(1<<DBG_UPC));
#endif DISTRIBUTION
-----END CODE SEGMENT-----

My suggestion is to change the '#if DISTRIBUTION' to '#if !(DISTRIBUTION)'
since in all other places (as specified in README.sbpcd) setting
DISTRIBUTION to 0 causes less output to the screen. In this one case,
however, setting it to 0 causes more output. This seems a little odd to
me.

Michael