Re: [PATCH net-next v2 2/5] net: marvell: prestera: allocate dummy net_device dynamically

From: Breno Leitao
Date: Fri Mar 29 2024 - 13:22:09 EST


On Fri, Mar 29, 2024 at 08:56:33AM -0700, Jakub Kicinski wrote:
> > @@ -682,6 +690,7 @@ static void prestera_sdma_switch_fini(struct prestera_switch *sw)
> > prestera_sdma_tx_fini(sdma);
> > prestera_sdma_rx_fini(sdma);
> > dma_pool_destroy(sdma->desc_pool);
> > + kfree(sdma->napi_dev);
>
> Why kfree()? Let's use free_netdev() consistently, in case one day
> we have to undo something alloc_netdev_dummy() has done.

I should have used free_netdev() in fact. I will update.