RE: [RFC PATCH v5 0/6] TPEBS counting mode support

[Wang, Weilin]

> -----Original Message-----
> From: Namhyung Kim <namhyung@xxxxxxxxxx>
> Sent: Thursday, March 28, 2024 12:43 PM
> To: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: Wang, Weilin <weilin.wang@xxxxxxxxx>; Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Ingo Molnar
> <mingo@xxxxxxxxxx>; Alexander Shishkin
> <alexander.shishkin@xxxxxxxxxxxxxxx>; Jiri Olsa <jolsa@xxxxxxxxxx>; Hunter,
> Adrian <adrian.hunter@xxxxxxxxx>; Kan Liang <kan.liang@xxxxxxxxxxxxxxx>;
> linux-perf-users@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Taylor, Perry
> <perry.taylor@xxxxxxxxx>; Alt, Samantha <samantha.alt@xxxxxxxxx>; Biggers,
> Caleb <caleb.biggers@xxxxxxxxx>
> Subject: Re: [RFC PATCH v5 0/6] TPEBS counting mode support
> 
> Hello,
> 
> On Thu, Mar 28, 2024 at 9:36 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > On Tue, Mar 26, 2024 at 1:29 PM <weilin.wang@xxxxxxxxx> wrote:
> > >
> > > From: Weilin Wang <weilin.wang@xxxxxxxxx>
> > >
> > > Changes in v5:
> > > - Update code and add comments for better code quality [Ian]
> > >
> > > v4: https://lore.kernel.org/all/20240312234921.812685-1-
> weilin.wang@xxxxxxxxx/
> > >
> > > Weilin Wang (6):
> > >   perf stat: Parse and find tpebs events when parsing metrics to prepare
> > >     for perf record sampling
> > >   perf stat: Fork and launch perf record when perf stat needs to get
> > >     retire latency value for a metric.
> > >   perf stat: Add retire latency values into the expr_parse_ctx to
> > >     prepare for final metric calculation
> > >   perf stat: Create another thread for sample data processing
> > >   perf stat: Add retire latency print functions to print out at the very
> > >     end of print out
> > >   perf vendor events intel: Add MTL metric json files
> > >
> > >  tools/perf/builtin-stat.c                     |  211 +-
> > >  .../arch/x86/meteorlake/metricgroups.json     |  127 +
> > >  .../arch/x86/meteorlake/mtl-metrics.json      | 2551
> +++++++++++++++++
> > >  tools/perf/util/data.c                        |    3 +
> > >  tools/perf/util/data.h                        |    5 +
> > >  tools/perf/util/metricgroup.c                 |   88 +-
> > >  tools/perf/util/metricgroup.h                 |   22 +-
> > >  tools/perf/util/stat-display.c                |   65 +
> > >  tools/perf/util/stat-shadow.c                 |   19 +
> > >  tools/perf/util/stat.h                        |    4 +
> > >  10 files changed, 3076 insertions(+), 19 deletions(-)
> > >  create mode 100644 tools/perf/pmu-
> events/arch/x86/meteorlake/metricgroups.json
> > >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-
> metrics.json
> >
> > Thanks Weilin,
> >
> > I'm happy with this series, my Reviewed-by is on all the patches.
> > Arnaldo/Namhyung, could we land this for the sake of Meteorlake metric
> > enablement? For the sake of tools, for the series:
> >
> > Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
> 
> Let me review this series again.

Thanks a lot Ian and Namhyung!

> 
> Thanks,
> Namhyung