Re: [PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

From: Dmitry Torokhov
Date: Thu Mar 28 2024 - 16:35:20 EST


Hi,

On Tue, Mar 26, 2024 at 09:17:18PM +0800, WangYuli wrote:
> Modified keyboard_ids in function ps2_is_keyboard_id
> for Lenovo Xiaoxin keyboard.
>
> Signed-off-by: yuanjianye <yuanjianye@xxxxxxxxxxxxx>
> Signed-off-by: shaoyang <shaoyang@xxxxxxxxxxxxx>
> Reviewed-by: huangbibo <huangbibo@xxxxxxxxxxxxx>
> Signed-off-by: helugang <helugang@xxxxxxxxxxxxx>
> Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx>
> ---
> drivers/input/serio/libps2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c
> index 6d78a1fe00c1..39d46526c56a 100644
> --- a/drivers/input/serio/libps2.c
> +++ b/drivers/input/serio/libps2.c
> @@ -189,6 +189,7 @@ bool ps2_is_keyboard_id(u8 id_byte)
> 0x5d, /* Trust keyboard */
> 0x60, /* NMB SGI keyboard, translated */
> 0x47, /* NMB SGI keyboard */
> + 0x83, /* Lenovo Xiaoxin keyboard */

Could you please tell me more about the keyboard? What ID does it use?
Majority of keyboards are using 0xab83, does your device forget to send
0xab by chance?

Thanks.

--
Dmitry