Re: [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled

From: Yosry Ahmed
Date: Thu Mar 28 2024 - 16:07:01 EST


On Thu, Mar 28, 2024 at 12:11 PM Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> On Mon, Mar 25, 2024 at 11:50:13PM +0000, Yosry Ahmed wrote:
> > There is no logical reason to refuse storing same-filled pages more
> > efficiently and opt for compression. Remove the userspace knob.
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
>
> I also think the non_same_filled_pages_enabled option should go
> away. Both of these tunables are pretty bizarre.

Happy to remove both in the next version :)

Thanks!