Re: [PATCH 5/5] x86/CPU/AMD: Track SNP host status with cc_platform_*()

From: Borislav Petkov
Date: Thu Mar 28 2024 - 09:44:13 EST


On Thu, Mar 28, 2024 at 12:51:17PM +0100, Jeremi Piotrowski wrote:
> Shouldn't this line be inside the cpu_has(c, X86_FEATURE_SEV_SNP) check?

The cc_vendor is not dependent on X86_FEATURE_SEV_SNP.

> How about turning this into a more specific check:
>
> if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP) &&

Why?

The check is "am I running as a hypervisor on baremetal".

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette