Re: [PATCH v2] crypto: bcm/spu2 - Add buffer size check

From: Herbert Xu
Date: Thu Mar 28 2024 - 06:57:40 EST


On Fri, Mar 22, 2024 at 11:59:15PM +0300, Aleksandr Mishin wrote:
> In spu2_dump_omd() value of ptr is increased by ciph_key_len
> instead of hash_iv_len which could lead to going beyond the
> buffer boundaries.
> Fix this bug by changing ciph_key_len to hash_iv_len.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver")
> Signed-off-by: Aleksandr Mishin <amishin@xxxxxxxxxx>
> ---
> v2: Fix commit message according to the Linux kernel rules
>
> drivers/crypto/bcm/spu2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt