Re: [PATCH v6 04/14] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

From: Shawn Sung (宋孝謙)
Date: Wed Mar 27 2024 - 22:51:05 EST


Hi CK,

On Mon, 2024-03-25 at 01:52 +0000, CK Hu (胡俊光) wrote:
>
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > > b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > > index 0ebeaf9830d83..2a767a823c83a 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > > @@ -288,6 +288,10 @@ unsigned int mtk_ovl_layer_nr(struct device
> > > *dev)
> > >
> > > unsigned int mtk_ovl_supported_rotations(struct device *dev)
> > > {
> > > + /*
> > > + * although currently OVL can only do reflection,
> > > + * reflect x + reflect y = rotate 180
> > > + */
>
> Sorry, this comment is not related to DRM_MODE_ROTATE_0, so after
> removing this comment,
>
> Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>
>

Got it. No problem. Will remove it from this series.

Thanks,
Shawn