Re: [PATCH v2 0/6] Improve visibility of writeback

From: Kemeng Shi
Date: Wed Mar 27 2024 - 21:59:59 EST



on 3/28/2024 1:40 AM, Andrew Morton wrote:
> On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> wrote:
>
>> This series tries to improve visilibity of writeback.
>
> Well... why? Is anyone usefully using the existing instrumentation?
> What is to be gained by expanding it further? What is the case for
> adding this code?
>
> I don't recall hearing of anyone using the existing debug
> instrumentation so perhaps we should remove it!
Hi Andrew, this was discussed in [1]. In short, I use the
debug files to test change in submit patchset [1]. The
wb_monitor.py is suggested by Tejun in [2] to improve
visibility of writeback.
I use the debug files to test change in [1]. The wb_monitor.py is suggested by Tejun
in [2] to improve visibility of writeback.
>
> Also, I hit a build error and a pile of warnings with an arm
> allnoconfig build.
>
Sorry for this, I only tested on x86. I will look into this and
fix the build problem in next version.

[1] https://lore.kernel.org/lkml/44e3b910-8b52-5583-f8a9-37105bf5e5b6@xxxxxxxxxxxxxxx/
[2] https://lore.kernel.org/lkml/a747dc7d-f24a-08bd-d969-d3fb35e151b7@xxxxxxxxxxxxxxx/
[3] https://lore.kernel.org/lkml/ZcUsOb_fyvYr-zZ-@xxxxxxxxxxxxxxx/