Re: [PATCH 2/3] dmaengine: xilinx: xdma: Fix synchronization issue

From: kernel test robot
Date: Wed Mar 27 2024 - 21:10:02 EST


Hi Louis,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 8e938e39866920ddc266898e6ae1fffc5c8f51aa]

url: https://github.com/intel-lab-lkp/linux/commits/Louis-Chauvet/dmaengine-xilinx-xdma-Fix-wrong-offsets-in-the-buffers-addresses-in-dma-descriptor/20240327-180155
base: 8e938e39866920ddc266898e6ae1fffc5c8f51aa
patch link: https://lore.kernel.org/r/20240327-digigram-xdma-fixes-v1-2-45f4a52c0283%40bootlin.com
patch subject: [PATCH 2/3] dmaengine: xilinx: xdma: Fix synchronization issue
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20240328/202403280803.IAFl90ZE-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240328/202403280803.IAFl90ZE-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403280803.IAFl90ZE-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/dma/xilinx/xdma.c:76: warning: Function parameter or struct member 'last_interrupt' not described in 'xdma_chan'
>> drivers/dma/xilinx/xdma.c:76: warning: Function parameter or struct member 'stop_requested' not described in 'xdma_chan'


vim +76 drivers/dma/xilinx/xdma.c

17ce252266c7f0 Lizhi Hou 2023-01-19 53
17ce252266c7f0 Lizhi Hou 2023-01-19 54 /**
17ce252266c7f0 Lizhi Hou 2023-01-19 55 * struct xdma_chan - Driver specific DMA channel structure
17ce252266c7f0 Lizhi Hou 2023-01-19 56 * @vchan: Virtual channel
17ce252266c7f0 Lizhi Hou 2023-01-19 57 * @xdev_hdl: Pointer to DMA device structure
17ce252266c7f0 Lizhi Hou 2023-01-19 58 * @base: Offset of channel registers
17ce252266c7f0 Lizhi Hou 2023-01-19 59 * @desc_pool: Descriptor pool
17ce252266c7f0 Lizhi Hou 2023-01-19 60 * @busy: Busy flag of the channel
17ce252266c7f0 Lizhi Hou 2023-01-19 61 * @dir: Transferring direction of the channel
17ce252266c7f0 Lizhi Hou 2023-01-19 62 * @cfg: Transferring config of the channel
17ce252266c7f0 Lizhi Hou 2023-01-19 63 * @irq: IRQ assigned to the channel
17ce252266c7f0 Lizhi Hou 2023-01-19 64 */
17ce252266c7f0 Lizhi Hou 2023-01-19 65 struct xdma_chan {
17ce252266c7f0 Lizhi Hou 2023-01-19 66 struct virt_dma_chan vchan;
17ce252266c7f0 Lizhi Hou 2023-01-19 67 void *xdev_hdl;
17ce252266c7f0 Lizhi Hou 2023-01-19 68 u32 base;
17ce252266c7f0 Lizhi Hou 2023-01-19 69 struct dma_pool *desc_pool;
17ce252266c7f0 Lizhi Hou 2023-01-19 70 bool busy;
17ce252266c7f0 Lizhi Hou 2023-01-19 71 enum dma_transfer_direction dir;
17ce252266c7f0 Lizhi Hou 2023-01-19 72 struct dma_slave_config cfg;
17ce252266c7f0 Lizhi Hou 2023-01-19 73 u32 irq;
70e8496bf693e1 Louis Chauvet 2024-03-27 74 struct completion last_interrupt;
70e8496bf693e1 Louis Chauvet 2024-03-27 75 bool stop_requested;
17ce252266c7f0 Lizhi Hou 2023-01-19 @76 };
17ce252266c7f0 Lizhi Hou 2023-01-19 77

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki