Re: [PATCH net-next v6 02/21] lib/test_bitmap: add tests for bitmap_{read,write}()

From: Andy Shevchenko
Date: Wed Mar 27 2024 - 12:12:57 EST


On Wed, Mar 27, 2024 at 04:23:39PM +0100, Alexander Lobakin wrote:
> From: Alexander Potapenko <glider@xxxxxxxxxx>
>
> Add basic tests ensuring that values can be added at arbitrary positions
> of the bitmap, including those spanning into the adjacent unsigned
> longs.
>
> Two new performance tests, test_bitmap_read_perf() and
> test_bitmap_write_perf(), can be used to assess future performance
> improvements of bitmap_read() and bitmap_write():
>
> [ 0.431119][ T1] test_bitmap: Time spent in test_bitmap_read_perf: 615253
> [ 0.433197][ T1] test_bitmap: Time spent in test_bitmap_write_perf: 916313
>
> (numbers from a Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz machine running
> QEMU).
>
> Signed-off-by: Alexander Potapenko <glider@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Acked-by: Yury Norov <yury.norov@xxxxxxxxx>

> Signed-off-by: Yury Norov <yury.norov@xxxxxxxxx>

This is a bit strange.
Can you explain the SoB chain in this patch and similar which have Yury's SoB?

> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

--
With Best Regards,
Andy Shevchenko