Re: [PATCH v2 2/3] dt-bindings: power: Add mediatek larb definition

From: Yu-chang Lee (李禹璋)
Date: Wed Mar 27 2024 - 06:02:05 EST


On Wed, 2024-03-27 at 09:39 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 27/03/2024 06:57, yu-chang.lee wrote:
> > Add Smart Multimedia Interface Local Arbiter to mediatek
> > power domain.
> >
> > Signed-off-by: yu-chang.lee <yu-chang.lee@xxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/power/mediatek,power-controller.yaml | 4
> ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> b/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> > index 8985e2df8a56..228c0dec5253 100644
> > --- a/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> > +++ b/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> > @@ -125,6 +125,10 @@ $defs:
> > $ref: /schemas/types.yaml#/definitions/phandle
> > description: phandle to the device containing the SMI
> register range.
> >
> > + mediatek,larb:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: phandle to the device containing the LARB
> register range.
>
> Why do you need it?
>
> Plus I also see mediatek,larbs and mediatek,larb-id... so now we have
> third one similar.
>
MM driver used "mediatek,larbs" for it larb node.
Power domain driver used "mediatek,larb".
"mediatek,larb-id" is for larb in dts.

The naming is no related to each other.

Best Regards,
Yu-chang.

> Best regards,
> Krzysztof
>