Re: [PATCH v1 0/7] ACPI: scan: A few ad-hoc cleanups

From: Kuppuswamy Sathyanarayanan
Date: Wed Mar 27 2024 - 01:50:20 EST



On 3/25/24 5:32 AM, Andy Shevchenko wrote:
> While looking for something else in the scan.c I noticed the room
> of improvement. Hence this series. Also bus.c patches, which some
> how were related to my research, but I think are independent from
> the scan.c improvements.

Changes looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> Andy Shevchenko (7):
> ACPI: bus: Make container_of() no-op where it makes sense
> ACPI: bus: Don't use "proxy" headers
> ACPI: scan: Replace infinite for-loop with finite while-loop
> ACPI: scan: Use list_first_entry_or_null() in acpi_device_hid()
> ACPI: scan: Move misleading comment to acpi_dma_configure_id()
> ACPI: scan: Use standard error checking pattern
> ACPI: scan: Introduce typedef:s for struct acpi_hotplug_context
> members
>
> drivers/acpi/dock.c | 48 +++++++++++++++--------------------------
> drivers/acpi/scan.c | 42 +++++++++++++++++-------------------
> include/acpi/acpi_bus.h | 28 +++++++++++++++---------
> 3 files changed, 55 insertions(+), 63 deletions(-)
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer