RE: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend

[Ratheesh Kannoth]

> From: Michael Chan <michael.chan@xxxxxxxxxxxx>
> Sent: Wednesday, March 27, 2024 10:39 AM
> To: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>; Nikita Kiryushin
> <kiryushin@xxxxxxxx>; Michael Chan <mchan@xxxxxxxxxxxx>; Pavan
> Chebbi <pavan.chebbi@xxxxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; lvc-
> project@xxxxxxxxxxxxxxxx
> Subject: [EXTERNAL] Re: [PATCH net-next v2] tg3: Remove residual error
> handling in tg3_suspend
> 
> Prioritize security for external emails: Confirm sender and content safety
> before clicking links or opening attachments
> 
> ----------------------------------------------------------------------
> On Tue, Mar 26, 2024 at 8:24 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> >
> > On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote:
> > > > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device
> *device)
> > > >  {
> > > Please address Michael Chan's comment to make this function return type
> to "void"
> > > instead of "int"
> >
> > It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work?
> 
> It won't work.  I only requested to change tg3_power_down_prepare() to
> void and it was done in v2:
> 
> https://lore.kernel.org/netdev/CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZk
> GaC9jfvFXrQ@xxxxxxxxxxxxxx/
Got it. Thanks.