Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled

From: A
Date: Tue Mar 26 2024 - 14:37:41 EST


On Tuesday, March 26th, 2024 at 14:29, Yazen Ghannam <yazen.ghannam@xxxxxxx> wrote:

>
>
> On 3/26/24 10:20, A wrote:
> [...]
>
> > > diff --git a/drivers/ras/debugfs.h b/drivers/ras/debugfs.h
> > > index 4749ccdeeba1..ab95831e7710 100644
> > > --- a/drivers/ras/debugfs.h
> > > +++ b/drivers/ras/debugfs.h
> > > @@ -4,6 +4,10 @@
> > >
> > > #include <linux/debugfs.h>
> > >
> > > +#if IS_ENABLED(DEBUG_FS)
> > > struct dentry *ras_get_debugfs_root(void);
> > > +#else
> > > +static inline struct dentry ras_get_debugfs_root(void) { return NULL; }
> > > +#endif / DEBUG_FS /
> > >
> > > #endif / RAS_DEBUGFS_H */
> >
> > this also works, just tested
> >
> > this time round, `make oldconfig` asks if i want to build RAS_FMPM, i built it as module, compilation succeeds.
>
>
> Thanks for testing!
>
> Would you mind including your "Tested-by" tag? I can include this when I
> send a proper patch.
>
> Thanks,
> Yazen

sure, tested-by: anthony s. knowles <akira.2020@xxxxxxxxxxxxxx>

kind regards,
a.s.k