Re: [PATCH 4/6] drm/msm/dp: Use function arguments for aux writes

From: Dmitry Baryshkov
Date: Tue Mar 26 2024 - 13:31:51 EST


On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
>
> From: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
>
> The dp_aux write operations takes the data to be operated on through a
> member of struct dp_catalog, rather than as an argument to the function.
>
> No state is maintained other than across the calling of the functions,
> so replace this member with a function argument.

Definitely yes, thank you!

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

>
> Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/dp/dp_aux.c | 9 +++------
> drivers/gpu/drm/msm/dp/dp_catalog.c | 8 ++++----
> drivers/gpu/drm/msm/dp/dp_catalog.h | 5 ++---
> 3 files changed, 9 insertions(+), 13 deletions(-)

--
With best wishes
Dmitry