Re: [PATCH v3 8/9] um: Fix -Wmissing-prototypes warnings for text_poke*

[Lucas De Marchi]

On Wed, Mar 06, 2024 at 06:19:24PM +0800, Tiwei Bie wrote:
> The prototypes for text_poke* are declared in asm/text-patching.h
> under arch/x86/include/. It's safe to include this header, as it's
> UML-aware (by checking CONFIG_UML_X86).

but would it work when building on something other than x86? Or is that
not a thing?

Lucas De Marchi

> This will address below -Wmissing-prototypes warnings:
>
> arch/um/kernel/um_arch.c:461:7: warning: no previous prototype for ‘text_poke’ [-Wmissing-prototypes]
> arch/um/kernel/um_arch.c:473:6: warning: no previous prototype for ‘text_poke_sync’ [-Wmissing-prototypes]
>
> Signed-off-by: Tiwei Bie <tiwei.btw@xxxxxxxxxxxx>
> ---
> arch/um/kernel/um_arch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index 7a9820797eae..e95f805e5004 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -23,6 +23,7 @@
> #include <asm/cpufeature.h>
> #include <asm/sections.h>
> #include <asm/setup.h>
> +#include <asm/text-patching.h>
> #include <as-layout.h>
> #include <arch.h>
> #include <init.h>
> --
> 2.34.1