Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled

From: Borislav Petkov
Date: Tue Mar 26 2024 - 10:11:44 EST


On Tue, Mar 26, 2024 at 09:41:41AM -0400, Yazen Ghannam wrote:
> This isn't true which is why the module doesn't fail to load if debugfs
> is not available.

How useful is this thing really without debugfs to dump records?

> This was my first thought too. However, besides not true as stated
> above, this also leaves the issue open for others to hit.

The others to hit? I don't get that part.

> I think the fix below (not tested) would be more appropriate.
>
> What do you think?

Sure, remove my fix and send me a tested version of yours and I'll swap
them if the driver is useful without debugfs...

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette