Re: [PATCH v3 5/6] media: imx335: Fix active area height discrepency

[Kieran Bingham]

Quoting Umang Jain (2024-03-19 07:27:11)
> The imx335 reports a recommended pixel area of - 2592x1944.
> The driver supported mode however limits it to height=1940.
> 
> Fix the height discrepency by correctly the value of height
> (with updates to vblank and mode registers).

"Fix the height discrepency by correcting the Y_OUT_SIZE,
HTRIMMING_START, and changing the WINMODE, followed by the corresponding
updates to reflect the new minimum vblanking periods."

I'm curious though - why does IMX335_REG_HTRIMMING_START jump /so/ much
here? Something to do with the WINMODE change?


Because I've seen this works and with the optional update to the commit
message:

Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>

> 
> Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/imx335.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index 7609dbc537b1..10a09830dbd6 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -247,13 +247,13 @@ static const int imx335_tpg_val[] = {
>  };
>  
>  /* Sensor mode registers */
> -static const struct cci_reg_sequence mode_2592x1940_regs[] = {
> +static const struct cci_reg_sequence mode_2592x1944_regs[] = {
>         {IMX335_REG_MODE_SELECT, 0x01},
>         {IMX335_REG_MASTER_MODE, 0x00},
> -       {IMX335_REG_WINMODE, 0x04},
> -       {IMX335_REG_HTRIMMING_START, 384},
> +       {IMX335_REG_WINMODE, 0x00},
> +       {IMX335_REG_HTRIMMING_START, 48},
>         {IMX335_REG_HNUM, 2592},
> -       {IMX335_REG_Y_OUT_SIZE, 1940},
> +       {IMX335_REG_Y_OUT_SIZE, 1944},
>         {IMX335_REG_AREA3_ST_ADR_1, 176},
>         {IMX335_REG_AREA3_WIDTH_1, 3928},
>         {IMX335_REG_OPB_SIZE_V, 0},
> @@ -404,15 +404,15 @@ static const u32 imx335_mbus_codes[] = {
>  /* Supported sensor mode configurations */
>  static const struct imx335_mode supported_mode = {
>         .width = 2592,
> -       .height = 1940,
> +       .height = 1944,
>         .hblank = 342,
> -       .vblank = 2560,
> -       .vblank_min = 2560,
> +       .vblank = 2556,
> +       .vblank_min = 2556,
>         .vblank_max = 133060,
>         .pclk = 396000000,
>         .reg_list = {
> -               .num_of_regs = ARRAY_SIZE(mode_2592x1940_regs),
> -               .regs = mode_2592x1940_regs,
> +               .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs),
> +               .regs = mode_2592x1944_regs,
>         },
>  };
>  
> -- 
> 2.43.0
>