Re: [PATCH v2] x86/dumpstack: uniform die messages prompt
From: Borislav Petkov
Date: Tue Mar 26 2024 - 06:43:35 EST
On Fri, Feb 02, 2024 at 03:45:12PM +0800, alexs@xxxxxxxxxx wrote:
> @@ -405,8 +407,8 @@ static void __die_header(const char *str, struct pt_regs *regs, long err)
> pr = IS_ENABLED(CONFIG_PREEMPT_RT) ? " PREEMPT_RT" : " PREEMPT";
>
> printk(KERN_DEFAULT
> - "%s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff, ++die_counter,
> - pr,
> + DIE_PROMPT "%s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff,
Why do you need this DIE_PROMPT if you can simply do:
"Oops: %s: %04lx... "
?
And yes, I think I'd prefer having an "oops" in there as it is a lot
more prominent. It is called a "kernel oops" everywhere.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette