Re: [PATCH v3 05/22] ASoC: mediatek: Add common machine soundcard driver probe mechanism

[AngeloGioacchino Del Regno]

Il 25/03/24 15:18, Mark Brown ha scritto:
> On Wed, Mar 13, 2024 at 12:01:30PM +0100, AngeloGioacchino Del Regno wrote:
> > Add a common machine soundcard driver probe function that supports both
> > DSP and AFE-direct usecases and also provides a hook for legacy machine
> > soundcard driver probe mechanisms.
> >
> > Note that the hook is there because, even for legacy probe, a lot of the
> > actual code can still be commonized, hence still reducing duplication
> > for the legacy devicetree retrocompatibility cases.
> >
> > This common probe function deprecates all of the inconsistent previous
> > probe mechanisms and aims to settle all of the MediaTek card drivers on
> > consistent and common devicetree properties describing wanted DAIs,
> > device specific DAI configuration and DAI links to codecs found on
> > each device/board.
>
> This breaks allmodconfig builds:

Oops. Forgot to test this commit without the next one constifying stuff around.
I'll recheck and make this one right. Good catch!

Thanks for notifying!

Cheers,
Angelo

> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In function ‘mtk_sof_dai_link_fixup’:
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:18:41: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>     18 |         struct mtk_sof_priv *sof_priv = soc_card_data->sof_priv;
>        |                                         ^~~~~~~~~~~~~
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In function ‘mtk_sof_card_probe’:
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:58:41: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>     58 |         struct mtk_sof_priv *sof_priv = soc_card_data->sof_priv;
>        |                                         ^~~~~~~~~~~~~
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In function ‘mtk_sof_find_tplg_be’:
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:76:41: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>     76 |         struct mtk_sof_priv *sof_priv = soc_card_data->sof_priv;
>        |                                         ^~~~~~~~~~~~~
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In function ‘mtk_sof_check_tplg_be_dai_link_fixup’:
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:116:41: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>    116 |         struct mtk_sof_priv *sof_priv = soc_card_data->sof_priv;
>        |                                         ^~~~~~~~~~~~~
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c: In function ‘mtk_sof_card_late_probe’:
> /build/stage/linux/sound/soc/mediatek/common/mtk-dsp-sof-common.c:147:41: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>    147 |         struct mtk_sof_priv *sof_priv = soc_card_data->sof_priv;
>        |                                         ^~~~~~~~~~~~~
> cc1: all warnings being treated as errors