Re: [RESEND][PATCH v2 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage

[Lukasz Luba]

On 3/25/24 19:17, Krzysztof Kozlowski wrote:
> On 22/03/2024 12:08, Lukasz Luba wrote:
> > When the voltage for OPPs is adjusted there is a need to also update
> > Energy Model framework. The EM data contains power values which depend
> > on voltage values. The EM structure is used for thermal (IPA governor)
> > and in scheduler task placement (EAS) so it should reflect the real HW
> > model as best as possible to operate properly.
> >
> > Based on data on Exynos5422 ASV tables the maximum power difference might
> > be ~29%. An Odroid-XU4 (with a random sample SoC in this chip lottery)
> > showed power difference for some OPPs ~20%. Therefore, it's worth to
> > update the EM.
> >
> > Signed-off-by: Lukasz Luba <lukasz.luba@xxxxxxx>
> > ---
> >   drivers/soc/samsung/exynos-asv.c | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
>
> I assume there is dependency, even though cover letter did not mention
> it, so:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thanks Krzysztof for the review. Yes, it touches driver in your tree
indeed. Hopefully it can goes smoothly via Rafael's tree with your
tag.

Regards,
Lukasz