Re: [PATCH 1/2] perf/x86/amd/core: Update stalled-cycles-* events for Zen 2 and later

[Ingo Molnar]

* Sandipan Das <sandipan.das@xxxxxxx> wrote:

> On 3/25/2024 8:04 PM, Ian Rogers wrote:
> > On Mon, Mar 25, 2024 at 12:48 AM Sandipan Das <sandipan.das@xxxxxxx> wrote:
> >>
> >> AMD processors based on Zen 2 and later microarchitectures do not
> >> support PMCx087 (instruction pipe stalls) which is used as the backing
> >> event for "stalled-cycles-frontend" and "stalled-cycles-backend". Use
> >> PMCx0A9 (cycles where micro-op queue is empty) instead to count frontend
> >> stalls and remove the entry for backend stalls since there is no direct
> >> replacement.
> >>
> >> Signed-off-by: Sandipan Das <sandipan.das@xxxxxxx>
> > 
> > This looks good to me. Should there be a Fixes tag for the sake of backports?
> > 
> 
> My bad. Yes, there should a fixes tag.
> 
> Fixes: 3fe3331bb285 ("perf/x86/amd: Add event map for AMD Family 17h")
> 
> Ingo, I see that you have already pushed this to the perf/urgent branch.
> Should I send a v2?

That's OK, no need, I've amended the commits in perf/urgent. 2019 is quite 
a way back for a Fixes tag though. :-)

Thanks,

	Ingo