Re: [PATCH] drm/amdkfd: return negative error code in svm_ioctl()

From: Su Hui
Date: Tue Mar 26 2024 - 01:41:43 EST


On 2024/3/25 22:09, Philip Yang wrote:


On 2024-03-25 02:31, Su Hui wrote:

Good catch, ioctl should return -errno. I will apply it to drm-next.

Reviewed-by: Philip Yang<philip.yang@xxxxxxx>

---
Ps: When I try to compile this file, there is a error :
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:28:10: fatal error: amdgpu_sync.h:
No such file or directory.

Maybe there are some steps I missed or this place need to be corrected?

Don't know how you compile the driver, amdgpu_sync.h is located under amdgpu folder, amdkfd/Makefile is included from amdgpu/Makefile, which set ccflag-y -I correctly.

Got it,  I should using 'make drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.o'
rather than 'make drivers/gpu/drm/amd/amdkfd/kfd_migrate.o'.

Thanks a lot!

Regards,
Su Hui