Re: [PATCH v2 RESEND] mm/mmap: convert all mas except mas_detach to vma iterator

From: Helge Deller
Date: Mon Mar 25 2024 - 16:24:33 EST


On 3/25/24 19:53, Andrew Morton wrote:
On Mon, 25 Mar 2024 14:32:58 +0800 Yajun Deng <yajun.deng@xxxxxxxxx> wrote:

There are two types of iterators mas and vmi in the current code. If the
maple tree comes from the mm structure, we can use the vma iterator. Avoid
using mas directly as possible.

Keep using mas for the mt_detach tree, since it doesn't come from the mm
structure.

Remove as many uses of mas as possible, but we will still have a few that
must be passed through in unmap_vmas() and free_pgtables().

Also introduce vma_iter_reset, vma_iter_{prev, next}_range_limit and
vma_iter_area_{lowest, highest} helper functions for using the vma
interator.


I assume Liam's earlier request still applies?

: Helge,
:
: Yajun has changed code that affects parisc with this patch, which hasn't
: been tested.
: ...
: Can you make sure that the expand_upwards() still functions on parisc?

Oh, I didn't noticed that request earlier.
Anyway, I now tested this patch on top of 6.9-rc1, and the kernel still
boots up nicely on parisc and as such expand_upwards() seem to work as before.
So, you may add:

Tested-by: Helge Deller <deller@xxxxxx> # parisc

Thanks!
Helge