Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)

From: Konrad Dybcio
Date: Mon Mar 25 2024 - 15:28:39 EST


On 24.03.2024 3:04 PM, Stanislav Jakubek wrote:
> Add a device tree for the Motorola Moto G (2013) smartphone based
> on the Qualcomm MSM8226 SoC.
>
> Initially supported features:
> - Buttons (Volume Down/Up, Power)
> - eMMC
> - Hall Effect Sensor
> - SimpleFB display
> - TMP108 temperature sensor
> - Vibrator
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@xxxxxxxxx>
> ---

[...]

> + hob-ram@f500000 {
> + reg = <0x0f500000 0x40000>,
> + <0x0f540000 0x2000>;
> + no-map;
> + };

Any reason it's in two parts? Should it be one contiguous region, or
two separate nodes?

lgtm otherwise