Re: [PATCH net] nfc: nci: Fix uninit-value in nci_dev_up

From: Krzysztof Kozlowski
Date: Mon Mar 25 2024 - 15:20:02 EST


On 14/03/2024 12:58, Paolo Abeni wrote:
> On Thu, 2024-03-14 at 18:59 +0900, Ryosuke Yasuoka wrote:
>> On Wed, Mar 13, 2024 at 10:01:27AM +0100, Krzysztof Kozlowski wrote:
>>> On 12/03/2024 15:56, Ryosuke Yasuoka wrote:
>>>
>>>> CPU: 1 PID: 5012 Comm: syz-executor935 Not tainted 6.7.0-syzkaller-00562-g9f8413c4a66f #0
>>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
>>>
>>> These two lines are not really relevant, it's a virtual platform, so
>>> whether this is Google or Amazon it does not matter, and your log paste
>>> is already quite long. If there is going to be any resend, I propose to
>>> drop.
>>
>> OK. Do you mean all these log messages that syzbot reported should be
>> dropped or I should leave only relavant messages?

No, I proposed to drop "these two lines". Please look at where people
put their comments and what do they trim from the response.

>
> It's not a big deal either way, but there is a quite established
> practice of including the whole splat.

Yeah, splat was fine in general.


Best regards,
Krzysztof