Re: [PATCH 2/4] workqueue: Reorder the fields in struct workqueue_attrs
From: Tejun Heo
Date: Mon Mar 25 2024 - 14:54:00 EST
Hello,
On Fri, Mar 08, 2024 at 05:42:51PM +0800, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@xxxxxxxxxxxx>
>
> So that its size is reduced from 40 to 32 in 64bit kernel, and it can be
> saved more when allocated with kmalloc() in alloc_workqueue_attrs().
Does this matter tho? Also, the sizing would be dependent on the number of
supported CPUs, right?
So, before, the order was - nice, cpumasks, affinity scope related stuff,
and then ordered flag. After, the cpumasks and affinity scope stuff are
mixed. Unless the saving is actually meaningful, I'd rather keep the current
ordering.
Thanks.
--
tejun