Re: [PATCH 01/26] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)

From: Jonathan Cameron
Date: Mon Mar 25 2024 - 13:23:34 EST


On Sun, 24 Mar 2024 16:18:04 -0700
ira.weiny@xxxxxxxxx wrote:

> From: Navneet Singh <navneet.singh@xxxxxxxxx>
>
> Per the CXL 3.1 specification software must check the Command Effects
> Log (CEL) to know if a device supports dynamic capacity (DC). If the
> device does support DC the specifics of the DC Regions (0-7) are read
> through the mailbox.
>
> Flag DC Device (DCD) commands in a device if they are supported.
> Subsequent patches will key off these bits to configure DCD.
>
> Signed-off-by: Navneet Singh <navneet.singh@xxxxxxxxx>
> Co-developed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
This aligns with similar existing code etc and the opcodes are right so
There is a vague argument that maybe we shouldn't claim to support the
command in the debug message at that point in the patch set, but I don't
think we really care either way as expectation is this set should go
in all together.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>