Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema

[Rob Herring]

On Sun, Mar 24, 2024 at 01:02:31AM +0100, Javier Carrasco wrote:
> On 3/24/24 00:37, Alexandre Belloni wrote:
> > On 23/03/2024 23:46:13+0100, Javier Carrasco wrote:
> >> Convert existing binding to dtschema to support validation.
> >>
> >> +required:
> >> +  - compatible
> >> +  - reg
> >> +  - reg-names
> >> +  - interrupts
> >> +
> >> +additionalProperties: false
> > 
> > This is not correct because at least start-year is supported. Please
> > check for all your other submissions too.
> > 
> 
> allOf:
>   - $ref: rtc.yaml#
> 
> is missing, and then
> 
> unvealuatedProperties: false
> 
> to account for that.
> 
> "start-year" is read in the RTC base class, so I wonder why so many RTC
> bindings add a reference to rtc.yaml, but then use
> 
> additionalProperties: false

They may have pre-dated support for 'unevaluatedProperties', or you can 
list out which properties are used from a referenced schema which 
disallows unlisted properties. There's no hard rule here. Either way is 
fine.

Other than this and my 1 other comment, this series looks fine to me.

Rob