Re: [PATCH v4 1/2] genirq/msi: add wrapper msi allocation API and export msi functions

From: Thomas Gleixner
Date: Mon Mar 25 2024 - 12:49:16 EST


On Tue, Mar 05 2024 at 10:00, Nipun Gupta wrote:

Subject: genirq/msi: Add MSI allocation helper and export MSI functions

> MSI functions can be for allocation and free can be directly
> used by the device drivers without any wrapper provided by
> bus drivers. So export these MSI functions.

s/can be for/for/ otherwise the sentence dos not make sense.

> Also, add a wrapper API to allocate MSIs providing only the
> number of IRQ's rather than range for simpler driver usage.

s/IRQ's/interrupts/

> Signed-off-by: Nipun Gupta <nipun.gupta@xxxxxxx>

Other than that:

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Alex, feel free to pick this up with the nitpicks resolved and route it
through your tree together with the VFIO driver.

Thanks,

tglx