Re: [PATCH v2 2/3] spi: omap2-mcspi: Add support for MULTI-mode

From: Mark Brown
Date: Mon Mar 25 2024 - 12:14:10 EST


On Fri, Feb 23, 2024 at 10:32:12AM +0100, Louis Chauvet wrote:
> Introduce support for MULTI-mode in the OMAP2 MCSPI driver. Currently, the
> driver always uses SINGLE mode to handle the chip select (CS). With this
> enhancement, MULTI-mode is enabled for specific messages, allowing for a
> shorter delay between CS enable and the message (some FPGA devices are
> sensitive to this delay).

This breaks an allmodconfig build:

/build/stage/linux/drivers/spi/spi-omap2-mcspi.c: In function ‘omap2_mcspi_prepare_message’:
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1280:17: error: "/*" within comment [-Werror=comment]
1280 | /*
|
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1265:14: error: unused variable ‘word_delay_is_zero’ [-Werror=unused-variable]
1265 | bool word_delay_is_zero;
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Attachment: signature.asc
Description: PGP signature