Re: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network

From: Rob Herring
Date: Mon Mar 25 2024 - 11:56:15 EST



On Sat, 23 Mar 2024 16:36:09 +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection. This is useful to distinguish those LEDs from LEDs that
> indicates status of wired "wan" connection.
>
> example (on stock fw):
>
> IIJ SA-W2 has "Mobile" LEDs that indicate status (no signal, too low,
> low, good) of mobile network connection via dongle connected to USB
> port.
>
> - no signal: (none, turned off)
> - too low: green:mobile & red:mobile (amber, blink)
> - low: green:mobile & red:mobile (amber, turned on)
> - good: green:mobile (turned on)
>
> Suggested-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@xxxxxxxxx>
> ---
> v1 -> v2
>
> - move _MOBILE before _MTD
> - improve the commit description
>
> include/dt-bindings/leds/common.h | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>