Re: [PATCH] mmc: dw_mmc: remove unneeded assignment

From: Ulf Hansson
Date: Mon Mar 25 2024 - 11:53:04 EST


On Thu, 7 Mar 2024 at 13:21, Muhammad Usama Anjum
<usama.anjum@xxxxxxxxxxxxx> wrote:
>
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")

Again, this isn't needed I think, so I have dropped it.

> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

Applied for next and by amending the commit message prefix to "mmc:
dw_mmc-hi3798mv200", thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> index 989ae8dda7228..96af693e3e37c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
> @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:
> --
> 2.39.2
>