Re: [PATCH v4] hwmon:Add EC Chip driver for Lenovo ThinkStation motherboards

From: Andy Shevchenko
Date: Mon Mar 25 2024 - 11:06:10 EST


On Wed, Mar 20, 2024 at 10:59:34AM -0700, Guenter Roeck wrote:
> On Fri, Mar 15, 2024 at 07:58:10AM -0400, David Ober wrote:
> > This addition adds in the ability for the system to scan
> > the EC chip in the Lenovo ThinkStation systems to get the
> > current fan RPM speeds the Maximum speed value for each
> > fan also provides the CPU, DIMM other thermal statuses
> >
> > Signed-off-by: David Ober <dober@xxxxxxxxxx>
> > Signed-off-by: David Ober <dober6023@xxxxxxxxx>
>
> Applied to hwmon-next.
>
> Please note that I'll push the branch after the commit window closed.

Hmm... Was it even compiled?

lenovo-ec-sensors.c:154:31: error: expected '}'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
^
lenovo-ec-sensors.c:154:27: note: to match this '{'
static int p8_fan_map[] = {0. 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14};
^

--
With Best Regards,
Andy Shevchenko