Re: [PATCH 1/2] platform/chrome: cros_kbd_led_backlight: Automatically enable keyboard backlight control if feature present in EC

[Stephen Horvath]

On 25/3/24 13:24, Tzung-Bi Shih wrote:
> If they aren't part of commit message, please put them after "---". Please
> separate to an independent patch if they fix different things.

Alright thanks, the separation thing did kinda occur to me after I'd 
send it, but I will do it next time.

> I'm not sure if it really fixes anything.  See [1] or [2].

Ahh okay, I guess it was probably a side effect of me breaking something 
else then, since the module only seemed to crash without that change. 
But I was also mildly confused how it seemed to work fine like that 
elsewhere though.

> By current design, the `drvdata` should be provided by either ACPI or OF match.

Yeah sorry, I didn't really know of a simpler way to do it, since it 
gets started from `mfd_add_hotplug_devices` in cros_ec_dev.c in this 
patch. I'll try and find a better way if I decide to make a v2.

> The patch is ruining the use cases in OF world (e.g. [3]).

I was kinda worried that the module would somehow launch twice, but I 
have a feeling that wouldn't be possible anyway.

Thanks for your feedback!
Steve