Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt registration policy

From: Tianyang Zhang
Date: Mon Mar 25 2024 - 04:48:35 EST


Hi, Thomas

在 2024/3/24 上午4:05, Thomas Gleixner 写道:
Tianyang!

On Fri, Mar 22 2024 at 18:14, Tianyang Zhang wrote:

Please do not top-post. See the 'Top-posting' chapter in:
https://people.kernel.org/tglx/notes-about-netiquette
Sorry, I will carefully read the document
Regarding "WHY", my understanding is that a convincing reason is needed
to explain the necessity of this patch.
Yes.

If so, can the last paragraph "This will be more conducive to fully
utilizing existing vectors to support more devices."

be considered a simple explanation?
Kinda, but ideally you describe it in a way that there is context for
the reader. Like this:

The fixed mapping between the LS7A interrupt source and the HT
interrupt vector prevents the utilization of the full interrupt vector
space which limits the number of devices in a system

Replace the fixed mapping with a dynamic mapping which allocates a
vector when an interrupt source is set up. This avoids that unused
sources prevent vectors from being used for other devices.

See?
Thank you for your demonstration. I will make the modifications according to the requirements

Thanks,

tglx


Thanks again

            Tianyang