Re: [PATCH 1/2] dt-bindings: iio: health: maxim,max30102: add max30101

From: Javier Carrasco
Date: Sun Mar 24 2024 - 15:05:59 EST


On 3/24/24 14:46, Jonathan Cameron wrote:
> On Thu, 21 Mar 2024 19:33:48 +0100
> Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:
>
>> The Maxim max30101 irs the replacement for the max30105, which is no
>> longer recommended for future designs.
>>
>> The max30101 does not require new properties, and it can be described
>> with the existing ones for the max30105.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
>
> Given there were no driver changes, is it fully compatible?
> i.e. Should we have a fallback compatible here?
>
> properties:
> compatible:
> oneOf:
> - items:
> - const: maxim,max30101
> - const: maxim,max30105
> - enum:
> - maxim,max30102
> - maxim,max30105
>
> So that a DTS file could use
> compatible = "maxim,max30101", "maxim,max30105"
> and work with older kernels as well as new ones that understand the new ID?
>

According to the manufacturer, it is fully compatible, and apart from
the pinout, I could not find any difference beyond the device description.

I like the idea of having a fallback compatible for older kernels, so I
will add it to v2 as you suggested.

Thanks and best regards,
Javier Carrasco