Re: [PATCH] cleanup: Add usage and style documentation
From: Lukas Wunner
Date: Sun Mar 24 2024 - 02:23:51 EST
On Sat, Mar 23, 2024 at 05:57:45PM -0700, Dan Williams wrote:
> Hmm, how about split the difference and teach scripts/kernel-doc to treat
> Peter's preferred markup for a C code example as a synonym, i.e.
> effectively a search and replace of a line with only:
>
> Ex.
>
> ...with:
>
> .. code-block:: c
>
> ...within a kernel-doc DOC: section?
>
> Might be easier said the done as I stare down a pile of perl. Maybe a
> perl wrangler will come along and take pity on this patch.
On line 757, there are two regexes...
#
# Regexes used only here.
#
my $sphinx_literal = '^[^.].*::$';
my $sphinx_cblock = '^\.\.\ +code-block::';
..which are (only) used immediately below in output_highlight_rst().
Amend those regexes to also match "Ex.", e.g.
my $sphinx_cblock = '^\.\.\ +(code-block::|Ex\.)';
Alternatively, add another variable definition and match against it
in output_highlight_rst().
A third alternative is to use the "::" syntax in lieu of
".. code-block:: c" in your C source file, if that causes
less eyesore for Peter. ;)
Thanks,
Lukas