RE: 32bit resctrl? (was Re: [PATCH v2] fs/resctrl: fix domid loss precision issue)

From: Luck, Tony
Date: Fri Mar 15 2024 - 20:08:29 EST


> Why? Making mon_data_bits::u larger in the way it has been done does not
> have any dependency on 32 or 64 builds unless I'm missing something.

That union is copied into the kernfs_node "priv" pointer field. So it has
to fit into whatever size the system is using as a pointer:

See:
mkdir_mondata_subdir()
->mon_addfile()

> Caring about 32biit resctrl on x86 is a pointless exercise.

Agree 100%

-Tony