Re: [PATCH 0/3] dts: arm64: sunxi: add initial support for t95 tv box

[Jernej Škrabec]

Dne petek, 15. marec 2024 ob 01:57:21 CET je Kamil Kasperski napisal(a):
> W dniu 14.03.2024 o 17:50, Jernej Škrabec pisze:
> > Dne četrtek, 14. marec 2024 ob 01:19:28 CET je Kamil Kasperski napisal(a):
> >> Hi Jernej, Andre!
> > Please no top posting as per rules.
> 
> Sure. I'm not used to this kind of work, so please bear the mistakes I make.

And line length should be 78 character max. Please read Linux netiquette.

> 
> >
> >> Thanks for the reply. My board has a name "H616-T95MAX-AXP313A-v3.0".
> > Ok, we for sure need to integrate this somehow to compatible string, since
> > there are at least two incompatible versions.
> 
> It's good idea to introduce dtsi with common configuration for both boxes and add 2 new dts files with compatible string
> "t95,t95max-axp313" and "t95,t95max-axp305" with separate PMIC configuration. Similarly as OrangePI Zero got handled.

Correct.

> 
> Not to mention, that it looks like arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts also has very similar configuration to my T95 box. Question is should we mix up the compatible strings for SoC?
> I know that H616 and H618 are almost identical SoCs, but if it's not only a matter of documentation it's still better idea to push new dts.

Not sure what do you mean. We can mix and match whatever DTSI we want. However,
board compatible reflect SoC in them. So yes, if it make sense, Transpeed 8k618-t
can share same common DTSI, just board level DTS will have H616 compatible.

Best regards,
Jernej

> 
> Best Regards,
> Kamil
> 
> >> I believe these boards are two different revisions and the one with 
> >> AXP313A is a newer one, besides incorrectly label as v3.0. Sharing 
> >> common configuration between boxes is also a good idea but for this 
> >> specific configuration I would be cautious. From my experience with this 
> >> board the default configuration for X96 Mate is not working at all. I 
> >> suspect because of the PMIC and DRAM differences.
> >>
> >> Memory installed in X96 Mate is DDR3L and in mine T95 it's DDR3, hynix 
> >> H5TQ2G43BFR, that requires 1.5V to operate.
> > PMIC is important difference, yes, but not DRAM. DDR3L is completely compatible
> > with DDR3. It just additionally supports lower voltages. Additionally, Linux
> > doesn't care about DRAM type and all. It's firmware responsibility to properly
> > initialize it.
> >
> > Best regards,
> > Jernej
> >
> >> The rest of configuration for both boards, like HDMI, MMC, EPHY and 
> >> audio codec seems to be the same across almost all H616-based boxes that 
> >> I've researched.
> >>
> >>
> >> Moreover please let me update the patches and send v2 that aligns with 
> >> mainline branch. I've incorrectly assumed to use sunxi fork instead of 
> >> master. Sorry!
> >>
> >> W dniu 13.03.2024 o 19:00, Jernej Škrabec pisze:
> >>> Dne sreda, 13. marec 2024 ob 18:38:08 CET je Andre Przywara napisal(a):
> >>>> On Wed, 13 Mar 2024 18:25:14 +0100
> >>>> Jernej Škrabec <jernej.skrabec@xxxxxxxxx> wrote:
> >>>>
> >>>>> Hi Kamil!
> >>>>>
> >>>>> Dne ponedeljek, 11. marec 2024 ob 18:47:47 CET je Kamil Kasperski napisal(a):
> >>>>>> T95 is a most commonly known for being a box with a pre-installed malware.
> >>>>>> It uses Allwinner H616 and comes with eMMC and DDR3 memory.
> >>>>>> This device comes with two versions - one with AXP305 PMIC and another with AXP313 PMIC.
> >>>>> I have this board and it always felt like a clone of X96 Mate, which is
> >>>>> already supported in kernel, except for broken sd card detection. Would it
> >>>>> make sense to unify those two boards and just overwrite or update parts here
> >>>>> that are not the same?
> >>>> I think the box you have is an older one, with the AXP305? IIUC, this is
> >>>> about a newer revision with the AXP313. There are quite some differences
> >>>> between the two PMICs, though it might still make sense to share the DTs,
> >>>> see the OrangePi Zero[23].
> >>> Right, mine is with AXP305. It has "T95MAX v4.0" printed on PCB.
> >>>
> >>> Kamil, does your board also have "MAX" mentioned somewhere?
> >>>
> >>> Best regards,
> >>> Jernej
> >>>
> >>>> Cheers,
> >>>> Andre
> >>>>
> >>>>>> Kamil Kasperski (3):
> >>>>>>    dt-bindings: vendor-prefixes: sunxi: add T95 to vendor-prefixes
> >>>>>>    dt-bindings: arm: sunxi: add t95 compatible string to list of known
> >>>>>>      boards
> >>>>>>    dts: arm64: sunxi: add initial support for T95 AXP313 tv box
> >>>>>>
> >>>>>>   .../devicetree/bindings/arm/sunxi.yaml        |   5 +
> >>>>>>   .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
> >>>>>>   arch/arm64/boot/dts/allwinner/Makefile        |   1 +
> >>>>>>   .../dts/allwinner/sun50i-h616-t95-axp313.dts  | 138 ++++++++++++++++++
> >>>>>>   4 files changed, 146 insertions(+)
> >>>>>>   create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-t95-axp313.dts
> >>>>>>
> >>>>>>    
> >>>>>
> >>>>>
> >>>>>
> >>>
> >>>
> >
> >
> >
> 
>